Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILateMixinLoader not working #15

Open
tox1cozZ opened this issue Jan 3, 2023 · 2 comments
Open

ILateMixinLoader not working #15

tox1cozZ opened this issue Jan 3, 2023 · 2 comments

Comments

@tox1cozZ
Copy link

tox1cozZ commented Jan 3, 2023

ILateMixinLoader is not called because in 1.7.10 ASMDataTable does not collect interface implementations: https://github.com/FalsePattern/GasStation/blob/master/src/main/java/com/falsepattern/gasstation/mixins/mixin/LoadControllerMixin.java#L41.
When I ported the mixinbooter from 1.12.2, I didn't pay attention to it.
I have an idea how to fix this: we need to create an marker annotation that we will add to our ILateMixinLoader implementation class.
If you have a better idea, go ahead and implement it in your mod, and I'll do it in a mixinbooterlegacy.
Thank you.

@Will0376
Copy link

The problem is still relevant.

@HowardZHY
Copy link

I sus it's not working on 1.8.9 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants