Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library not Compatible with React Native 0.65.1 #2094

Closed
Priiyam opened this issue Aug 27, 2021 · 6 comments
Closed

Library not Compatible with React Native 0.65.1 #2094

Priiyam opened this issue Aug 27, 2021 · 6 comments
Labels

Comments

@Priiyam
Copy link

Priiyam commented Aug 27, 2021

Issue Description

  • react-native-gifted-chat library is not compatible with React Native 0.65.1

Steps to Reproduce / Code Snippets

  • Upgrade react native project to 0.65.1 to reproduce the following error:

    TypeError: _reactNative.Keyboard.removeListener is not a function. (In '_reactNative.Keyboard.removeListener('keyboardWillShow', invertibleProps.onKeyboardWillShow)', '_reactNative.Keyboard.removeListener' is undefined)

    This error is located at:
    in MessageContainer (at GiftedChat.js:343)
    in RCTView (at View.js:32)
    in View (at GiftedChat.js:337)
    in RCTView (at View.js:32)
    in View (at GiftedChat.js:408)
    in RCTView (at View.js:32)
    in View (at ActionSheet/index.tsx:72)
    in RCTView (at View.js:32)
    in View (at ActionSheet/index.tsx:80)
    in ActionSheet (at ActionSheetProvider.tsx:31)
    in ActionSheetProvider (at GiftedChat.js:407)
    in RCTView (at View.js:32)
    in View (at SafeAreaView.js:41)
    in SafeAreaView (at GiftedChat.js:406)
    ...

Expected Results

  • Should work normally with react native 0.65.1

Additional Information

  • Nodejs version: v14.15.1
  • React version: 17.0.2
  • React Native version: 0.65.1
  • react-native-gifted-chat version: 0.16.3
  • Platform(s) (iOS, Android, or both?): Both
  • TypeScript version: NA
@rusakovic
Copy link

confirm

@java-james
Copy link

java-james commented Sep 1, 2021

+1
Looks like master doesn't include the listeners causing the issue.
Only remainder is replaced with non deprecated API and looks like some were removed here:

d76af9f

Are we just waiting on a release?

Edit: patching will resolve the failure until then as mentioned in related issue #2090

@FaisalKhawaj
Copy link

I have tried react native gifted chat in react native 0.65 . but it is giving me the error. It was working fine in previous version . Can someone please tell me how to fix this ?

@rayhk6
Copy link

rayhk6 commented Sep 6, 2021

I have tried react native gifted chat in react native 0.65 . but it is giving me the error. It was working fine in previous version . Can someone please tell me how to fix this ?

#2090 Please check if this helps

@FaisalKhawaj
Copy link

Yes, It worked now.
This file was in nodemodules-giftedchat-messageContainer.js .
Thank you so much

@stale
Copy link

stale bot commented Apr 17, 2022

Sorry, but this issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. BTW Thank you for your contributions 😀 !!!

@stale stale bot added the wontfix label Apr 17, 2022
@stale stale bot closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants