binary fuse filter: allow size=0,size=1,size=2 and add tests #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dabe365 checks were added to prevent creation of filters with `size <= 1`, and while these incredibly small sizes are not particularly useful in a binary fuse filter, keeping the property that all sizes `[0..N]` are allowed is nice due to the fact that, if the restriction is in place, you must: * Verify your set length is >= 1. * If it isn't, use a separate code path to lookup and encode your 0, 1, or 2 keys outside the binary fuse filter. And also handle encoding that to a file if you e.g. intend to serialize the filter to disk. With this change, input sizes 0,1,2 are allowed and consume no more memory than size=3 (there is no overflow condition in calculating the array length.) Also added a few tests for these three edge cases. Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
slimsag
added a commit
to hexops/fastfilter
that referenced
this pull request
Aug 21, 2021
Mirroring FastFilter/xor_singleheader#27 Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
1 task
slimsag
added a commit
to hexops/fastfilter
that referenced
this pull request
Aug 21, 2021
Mirroring FastFilter/xor_singleheader#27 Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
|
Why not! |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dabe365 checks were added to prevent
creation of filters with
size <= 1, and while these incredibly smallsizes are not particularly useful in a binary fuse filter, keeping the
property that all sizes
[0..N]are allowed is nice due to the factthat, if the restriction is in place, you must:
outside the binary fuse filter. And also handle encoding that to a file if you
e.g. intend to serialize the filter to disk.
With this change, input sizes 0,1,2 are allowed and consume no more
memory than size=3 (there is no overflow condition in calculating the
array length.)
Also added a few tests for these three edge cases.
Ref #26
Signed-off-by: Stephen Gutekanst stephen@hexops.com