Skip to content

Fix #5354: do not write cglibs Callback[] getCallbacks() (3.x) #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 21, 2025
Merged

Fix #5354: do not write cglibs Callback[] getCallbacks() (3.x) #5357

merged 8 commits into from
Oct 21, 2025
+12 −12

Conversation

@rwinch
Copy link
Contributor

@rwinch rwinch commented Oct 20, 2025 •
edited by cowtowncoder
Loading

Fixes #5354

@rwinch rwinch mentioned this pull request Oct 20, 2025
Closed
1 task
@cowtowncoder cowtowncoder changed the title Do not write cglibs Callback[] getCallbacks() Do not write cglibs Callback[] getCallbacks() (3.x) Oct 20, 2025
@cowtowncoder cowtowncoder mentioned this pull request Oct 20, 2025
Merged
cowtowncoder
cowtowncoder approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cowtowncoder
Copy link
Member

Looks good @rwinch ! Just one thing before I can merge (non-test-)code changes: unless we have gotten CLA for you (apologies if I missed it, tried to check), would need one now, from:

https://github.com/FasterXML/jackson/blob/main/contributor-agreement.pdf

It only needs to be sent once and covers all future contributions. The usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com.
Once I got it I'll proceed with merge and the fix will make it in 3.0.1 that I hope to release this week!

Thank you again for both reporting the issue and providing the fix!

cowtowncoder
cowtowncoder approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwinch
Copy link
Contributor Author

rwinch commented Oct 21, 2025

@cowtowncoder Thanks for the reply. I'm working on sorting out the CLA with my employer and will get back to you as soon as I can.

@rwinch
Copy link
Contributor Author

rwinch commented Oct 21, 2025

@cowtowncoder Thank you for your patience. I've submitted the CLA

@cowtowncoder cowtowncoder added the cla-received PR already covered by CLA (optional label) label Oct 21, 2025
@cowtowncoder cowtowncoder changed the title Do not write cglibs Callback[] getCallbacks() (3.x) Fix #5354: do not write cglibs Callback[] getCallbacks() (3.x) Oct 21, 2025
@cowtowncoder cowtowncoder added this to the 3.0.1 milestone Oct 21, 2025
cowtowncoder
cowtowncoder approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cowtowncoder cowtowncoder merged commit b0ef3c0 into FasterXML:3.x Oct 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees

No one assigned

Labels

cla-received PR already covered by CLA (optional label)

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

jackson-databind 3.0.0 renders callbacks property from Spring CGLIB Proxy

2 participants

@rwinch @cowtowncoder