Merge pull request #858 from k163377/refactor-find-creator

Refactor findDefaultCreator
FasterXML · Nov 23, 2024 · ed013a7 · ed013a7
2 parents a15c278 + f603e8f
commit ed013a7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/release-notes/CREDITS-2.x b/release-notes/CREDITS-2.x
@@ -18,6 +18,7 @@ Contributors:
 # 2.19.0 (not yet released)
 
 WrongWrong (@k163377)
+* #858: Refactor findDefaultCreator
 * #839: Remove useKotlinPropertyNameForGetter and unify with kotlinPropertyNameAsImplicitName
 * #835: Remove old SingletonSupport class and unified with KotlinFeature.SingletonSupport
 

diff --git a/release-notes/VERSION-2.x b/release-notes/VERSION-2.x
@@ -18,6 +18,7 @@ Co-maintainers:
 
 2.19.0 (not yet released)
 
+#858: Minor performance improvement of findDefaultCreator in edge cases.
 #839: Remove useKotlinPropertyNameForGetter and unify with kotlinPropertyNameAsImplicitName.
 #835: Remove old SingletonSupport class and unified with KotlinFeature.SingletonSupport.
 

diff --git a/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinNamesAnnotationIntrospector.kt b/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinNamesAnnotationIntrospector.kt
@@ -91,13 +91,11 @@ internal class KotlinNamesAnnotationIntrospector(
     ): PotentialCreator? {
         val kClass = valueClass.creatableKotlinClass() ?: return null
 
-        val propertyNames = kClass.memberProperties.map { it.name }.toSet()
-
-        val defaultCreator = kClass.let { _ ->
-            // By default, the primary constructor or the only publicly available constructor may be used
-            val ctor = kClass.primaryConstructor ?: kClass.constructors.takeIf { it.size == 1 }?.single()
-            ctor?.takeIf { it.isPossibleCreator(propertyNames) }
-        }
+        val defaultCreator = kClass.primarilyConstructor()
+            ?.takeIf { ctor ->
+                val propertyNames = kClass.memberProperties.map { it.name }.toSet()
+                ctor.isPossibleCreator(propertyNames)
+            }
             ?: return null
 
         return declaredConstructors.find {
@@ -115,6 +113,9 @@ private fun AnnotatedClass.creatableKotlinClass(): KClass<*>? = annotated
     .takeIf { it.isKotlinClass() && !it.isEnum }
     ?.kotlin
 
+// By default, the primary constructor or the only publicly available constructor may be used
+private fun KClass<*>.primarilyConstructor() = primaryConstructor ?: constructors.singleOrNull()
+
 private fun KFunction<*>.isPossibleCreator(propertyNames: Set<String>): Boolean = 0 < parameters.size
     && !isPossibleSingleString(propertyNames)
     && parameters.none { it.name == null }