Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with dof handler on true subdomains #967

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

termi-official
Copy link
Member

Resolves #966 on master.

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (231c8b1) to head (2e84583).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #967   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          36       36           
  Lines        5438     5440    +2     
=======================================
+ Hits         5095     5097    +2     
  Misses        343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@termi-official termi-official added the awaiting review PR is finished from the authors POV, waiting for feedback label Jun 1, 2024
Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/test_mixeddofhandler.jl Show resolved Hide resolved
Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to test the new behavior, and just reduce the test mesh since more cells and vector interpolations doesn't really test anything more...

test/test_mixeddofhandler.jl Outdated Show resolved Hide resolved
test/test_mixeddofhandler.jl Outdated Show resolved Hide resolved
test/test_mixeddofhandler.jl Show resolved Hide resolved
test/test_mixeddofhandler.jl Outdated Show resolved Hide resolved
termi-official and others added 2 commits June 5, 2024 20:07
Co-authored-by: Knut Andreas Meyer <knutam@gmail.com>
Co-authored-by: Knut Andreas Meyer <knutam@gmail.com>
@fredrikekre fredrikekre merged commit 3ae61fa into master Jun 5, 2024
11 checks passed
@fredrikekre fredrikekre deleted the do/ndofs-per-cell-safetycheck branch June 5, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR is finished from the authors POV, waiting for feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CellIterator causes a OutOfMemoryError
3 participants