Implement _GROW_TIER2_FRAME without adding tier2_extra_size #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had added an extra cleanup abstraction a while back that has turned out to be unnecessary.
…llow errors (python#115321)
… Modules Handle Reloading Properly (pythongh-115493) The problem manifested when the .py module got reloaded and the corresponding extension module didn't. The .py module registers types with the extension and the extension was not allowing that to happen more than once. The solution: let it happen more than once.
Remove sentence in Tools/c-analyzer/README referring to deleted ignore-globals.txt.
…/preview2 primitives (python#116327) * pythonGH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.2/preview2 primitives * Add the configure changes * Update `wasm_build.py`
…ardRef with empty string arg (python#116341)
closure is not a function pointer, it is a user data pointer.
…ith ASCII charset (pythonGH-116125)
…honGH-115771) urllib.parse functions parse_qs() and parse_qsl() now support bytes arguments containing raw and percent-encoded non-ASCII data.
…-116328) This includes adding pickle support to various classes, and small changes to improve the maintainability of the low-level _xxinterpqueues module.
Signed-off-by: cui fliter <imcusg@gmail.com>
This adjusts `length` rather than using `length+1` all over the place.
…ongh-116369) I accidentally introduced the warning in pythongh-116328.
…ython#116343) This sets `MI_DEBUG` to `2` in debug builds to enable `mi_assert_internal()` calls. Expensive internal assertions are not enabled. This also disables an assertion in free-threaded builds that would be triggered by the free-threaded GC because we traverse heaps that are not owned by the current thread.
Amend wording after pythongh-116019 was merged.
|
Alas, when I run the tests (in python#116390) I get crashes in all the Linux JIT builds. Since all I have is a Mac (whose JIT tests pass) I cannot easily debug this. :-( |
|
I renamed the branch, redid the merge, and Brandt fixed the JIT issue for me (it wasn't a JIT issue, and I'm still unsure why it works, but it seems to work). I'll make a new PR later when I'm more confident. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll back the changes to ceval.c and pycore_frame.c, in favor of this implementation of
_GROW_TIER2_FRAME:This requires disabling one assert in ceval.c and rolling back the changes to test_sys.py.
@Fidget-Spinner This is what I proposed here.