Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not add module attribute in case of ibc messages (backport #1079) #1092

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 24, 2023

Description

This patch backports #1079 into v0.48.0 release candidate.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1092 (93505cd) into rc/v0.48.0-rcx (0538b80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1092   +/-   ##
===============================================
  Coverage           69.70%   69.70%           
===============================================
  Files                 642      642           
  Lines               67285    67287    +2     
===============================================
+ Hits                46900    46902    +2     
  Misses              18203    18203           
  Partials             2182     2182           
Files Changed Coverage Δ
baseapp/baseapp.go 79.22% <100.00%> (+0.09%) ⬆️

@zemyblue zemyblue added this to the v0.48.0 milestone Aug 24, 2023
@0Tech 0Tech marked this pull request as ready for review August 24, 2023 10:16
@0Tech 0Tech requested review from zemyblue and jaeseung-bae August 24, 2023 10:16
@0Tech 0Tech merged commit c057de9 into Finschia:rc/v0.48.0-rcx Aug 24, 2023
@0Tech 0Tech deleted the 1079 branch August 24, 2023 10:20
0Tech added 2 commits August 24, 2023 18:49
…1079)

* Do not add `module` attribute in case of ibc

* Update CHANGELOG.md

* Add test

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants