Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow codecov job to filter unnecessary files #197

Merged
merged 2 commits into from
May 15, 2021

Conversation

kukugi
Copy link
Contributor

@kukugi kukugi commented May 14, 2021

Description

modify path used for filter unnecessary files when codecov job running (line/lbm-sdk -> line/lbm-sdk/v2)
pb.go, pb.gw.go is already ignored by codecov.yml
modify go file for running ci jobs

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #197 (218fe95) into v2/develop (1f739c5) will decrease coverage by 1.53%.
The diff coverage is 70.14%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v2/develop     #197      +/-   ##
==============================================
- Coverage       54.99%   53.45%   -1.54%     
==============================================
  Files             812      653     -159     
  Lines           51487    47289    -4198     
==============================================
- Hits            28317    25280    -3037     
+ Misses          20211    19157    -1054     
+ Partials         2959     2852     -107     
Impacted Files Coverage Δ
client/grpc/tmservice/query.pb.go 32.27% <ø> (ø)
client/grpc/tmservice/query.pb.gw.go 30.06% <ø> (ø)
client/keys/root.go 100.00% <ø> (ø)
client/keys/utils.go 44.11% <ø> (+5.22%) ⬆️
crypto/armor.go 85.89% <ø> (ø)
crypto/keys/ed25519/ed25519.go 67.34% <ø> (ø)
crypto/keys/multisig/codec.go 100.00% <ø> (ø)
crypto/keys/secp256k1/secp256k1.go 86.79% <ø> (ø)
server/config/toml.go 18.18% <ø> (ø)
simapp/test_helpers.go 8.41% <0.00%> (+7.91%) ⬆️
... and 198 more

@egonspace egonspace self-requested a review May 15, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants