Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge release patch #370

Merged
merged 7 commits into from
Nov 2, 2021
Merged

fix: merge release patch #370

merged 7 commits into from
Nov 2, 2021

Conversation

egonspace
Copy link

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@cc78696). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head be3591b differs from pull request most recent head e6fa9a3. Consider uploading reports for the commit e6fa9a3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage        ?   53.13%           
=======================================
  Files           ?      643           
  Lines           ?    67330           
  Branches        ?        0           
=======================================
  Hits            ?    35773           
  Misses          ?    28610           
  Partials        ?     2947           

@egonspace egonspace requested review from 0Tech and dudong2 November 2, 2021 00:36
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.md Outdated
Comment on lines 8 to 9

### Improvements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Improvements

Duplicated improvements!

Woosang Son added 3 commits November 2, 2021 10:23
* fix: check bech32 address format in bank query

* docs: modify release_changelog; wrong PR number

* docs: modify release changelog
@egonspace egonspace merged commit 2c67a50 into main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants