From 77a069619a5c964f6bc717b4a0f6c850be34cbec Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Thu, 24 Mar 2022 04:42:12 +0000 Subject: [PATCH 1/7] fix: change the default output format into "" --- client/config/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/config/config.go b/client/config/config.go index 49ed35d78a..8020fd4670 100644 --- a/client/config/config.go +++ b/client/config/config.go @@ -12,7 +12,7 @@ import ( const ( chainID = "" keyringBackend = "os" - output = "text" + output = "" node = "tcp://localhost:26657" broadcastMode = "sync" ) From a5362423517d48faffbeb8fc84c47565d7009c09 Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Thu, 24 Mar 2022 04:45:21 +0000 Subject: [PATCH 2/7] docs: add a comment to provide more information about the override --- client/config/toml.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/config/toml.go b/client/config/toml.go index 0393a5b6ac..621ec3a1f9 100644 --- a/client/config/toml.go +++ b/client/config/toml.go @@ -20,7 +20,7 @@ const defaultConfigTemplate = `# This is a TOML config file. chain-id = "{{ .ChainID }}" # The keyring's backend, where the keys are stored (os|file|kwallet|pass|test|memory) keyring-backend = "{{ .KeyringBackend }}" -# CLI output format (text|json) +# CLI output format (text|json), it will override the default values of both query and tx. output = "{{ .Output }}" # : to Tendermint RPC interface for this chain node = "{{ .Node }}" From 06533681ec7781c5c042dece5b6a743c213448c2 Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Thu, 24 Mar 2022 04:56:52 +0000 Subject: [PATCH 3/7] docs: update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 10bc105abe..5b5ad3db45 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,6 +44,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Bug Fixes * (x/wasm) [\#453](https://github.com/line/lbm-sdk/pull/453) modify wasm grpc query api path +* (client) [\#476](https://github.com/line/lbm-sdk/pull/476) change the default value of the client output format in the config ### Breaking Changes From 0c7dd80a71a472a5b82be0b17db0182a8bb8feec Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Thu, 24 Mar 2022 08:17:24 +0000 Subject: [PATCH 4/7] Revert "fix: change the default output format into """ This reverts commit 77a069619a5c964f6bc717b4a0f6c850be34cbec. --- client/config/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/config/config.go b/client/config/config.go index 8020fd4670..49ed35d78a 100644 --- a/client/config/config.go +++ b/client/config/config.go @@ -12,7 +12,7 @@ import ( const ( chainID = "" keyringBackend = "os" - output = "" + output = "text" node = "tcp://localhost:26657" broadcastMode = "sync" ) From e1c97add6a4ac38be74c02b11ce1b04b4a2b9afd Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Thu, 24 Mar 2022 08:42:24 +0000 Subject: [PATCH 5/7] Revert "docs: add a comment to provide more information about the override" This reverts commit a5362423517d48faffbeb8fc84c47565d7009c09. --- client/config/toml.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/config/toml.go b/client/config/toml.go index 621ec3a1f9..0393a5b6ac 100644 --- a/client/config/toml.go +++ b/client/config/toml.go @@ -20,7 +20,7 @@ const defaultConfigTemplate = `# This is a TOML config file. chain-id = "{{ .ChainID }}" # The keyring's backend, where the keys are stored (os|file|kwallet|pass|test|memory) keyring-backend = "{{ .KeyringBackend }}" -# CLI output format (text|json), it will override the default values of both query and tx. +# CLI output format (text|json) output = "{{ .Output }}" # : to Tendermint RPC interface for this chain node = "{{ .Node }}" From 9156ebbd404359c94337cf3eec6943998d43c590 Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Thu, 24 Mar 2022 08:51:04 +0000 Subject: [PATCH 6/7] Revert "Revert "fix: change the default output format into """" This reverts commit 0c7dd80a71a472a5b82be0b17db0182a8bb8feec. --- client/config/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/config/config.go b/client/config/config.go index 49ed35d78a..8020fd4670 100644 --- a/client/config/config.go +++ b/client/config/config.go @@ -12,7 +12,7 @@ import ( const ( chainID = "" keyringBackend = "os" - output = "text" + output = "" node = "tcp://localhost:26657" broadcastMode = "sync" ) From a2bd0bb575eecb2d9b41de7eea48bfeb22ca65a0 Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Thu, 24 Mar 2022 09:04:58 +0000 Subject: [PATCH 7/7] Revert "Revert "docs: add a comment to provide more information about the override"" This reverts commit e1c97add6a4ac38be74c02b11ce1b04b4a2b9afd. --- client/config/toml.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/config/toml.go b/client/config/toml.go index 0393a5b6ac..35b449d9db 100644 --- a/client/config/toml.go +++ b/client/config/toml.go @@ -20,7 +20,7 @@ const defaultConfigTemplate = `# This is a TOML config file. chain-id = "{{ .ChainID }}" # The keyring's backend, where the keys are stored (os|file|kwallet|pass|test|memory) keyring-backend = "{{ .KeyringBackend }}" -# CLI output format (text|json) +# CLI output format (text|json), it will override the default values of both query and tx output = "{{ .Output }}" # : to Tendermint RPC interface for this chain node = "{{ .Node }}"