Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add pool to the state of x/foundation #693

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 4, 2022

Description

This patch would add own pool (has treasury for now). Because the treasury can begin with a non-zero value, we should state the info in the its own genesis.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #693 (6c9264a) into main (551bc1c) will increase coverage by 0.01%.
The diff coverage is 97.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   61.15%   61.17%   +0.01%     
==========================================
  Files         873      873              
  Lines       98421    98463      +42     
==========================================
+ Hits        60192    60237      +45     
+ Misses      34644    34639       -5     
- Partials     3585     3587       +2     
Impacted Files Coverage Δ
x/foundation/keeper/keys.go 100.00% <ø> (ø)
x/foundation/keeper/treasury.go 94.54% <97.36%> (+7.58%) ⬆️
x/foundation/foundation.go 81.52% <100.00%> (+0.34%) ⬆️
x/foundation/genesis.go 76.85% <100.00%> (+0.66%) ⬆️
x/foundation/keeper/genesis.go 80.76% <100.00%> (+0.24%) ⬆️
x/collection/msgs.go 41.66% <0.00%> (-1.67%) ⬇️
x/wasm/keeper/keeper.go 85.80% <0.00%> (-0.37%) ⬇️
x/token/msgs.go 36.54% <0.00%> (+1.52%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/token/validation.go 90.90% <0.00%> (+20.00%) ⬆️

@0Tech 0Tech marked this pull request as ready for review October 4, 2022 09:33
@0Tech 0Tech requested review from zemyblue and dudong2 October 4, 2022 09:33
@0Tech 0Tech requested a review from zemyblue October 5, 2022 03:30
@0Tech 0Tech merged commit 954dec7 into Finschia:main Oct 5, 2022
@0Tech 0Tech deleted the foundation_refactor_pool branch October 5, 2022 23:46
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants