-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modify proto pubkey regisiter name for IBC relayer compatibility #762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 66.54% 66.64% +0.10%
==========================================
Files 285 285
Lines 37919 37919
==========================================
+ Hits 25232 25271 +39
+ Misses 10883 10850 -33
+ Partials 1804 1798 -6
|
https://github.com/tendermint/tendermint/blob/main/crypto/encoding/codec.go |
Yeah I think it's possible. But I have heard that our repo will be converted with cometbft soon. So I just tried to not change as much as possible. Is it better to replace with tendermint now? @ulbqb |
That’s make sense. |
Description
tendermint-rs
. It renames fields astendermint.crypto.*
viaserde
for PublicKey. (ref)finschia-sdk
.sdk
registers their amino types here.Closes: #XXX