From ad81a1b656586226f8b7b8d1123c52b0f3f2e6f7 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Thu, 15 Dec 2022 23:37:11 +0100 Subject: [PATCH] fix: don't log when package is incompatible and `exclusive` option is used --- .../app/revanced/cli/command/MainCommand.kt | 2 +- .../app/revanced/utils/patcher/Patcher.kt | 19 +++++++++---------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/main/kotlin/app/revanced/cli/command/MainCommand.kt b/src/main/kotlin/app/revanced/cli/command/MainCommand.kt index aff17a0f..c751933a 100644 --- a/src/main/kotlin/app/revanced/cli/command/MainCommand.kt +++ b/src/main/kotlin/app/revanced/cli/command/MainCommand.kt @@ -87,7 +87,7 @@ internal object MainCommand : Runnable { names = ["--exclusive"], description = ["Only installs the patches you include, not including any patch by default"] ) - var defaultExclude = false + var exclusive = false @Option(names = ["-i", "--include"], description = ["Include patches"]) var includedPatches = arrayOf() diff --git a/src/main/kotlin/app/revanced/utils/patcher/Patcher.kt b/src/main/kotlin/app/revanced/utils/patcher/Patcher.kt index f9912abe..c6e86cea 100644 --- a/src/main/kotlin/app/revanced/utils/patcher/Patcher.kt +++ b/src/main/kotlin/app/revanced/utils/patcher/Patcher.kt @@ -18,18 +18,9 @@ fun Patcher.addPatchesFiltered(allPatches: List>>) { allPatches.forEach patchLoop@{ patch -> val compatiblePackages = patch.compatiblePackages val patchName = patch.patchName - - val prefix = "Skipping $patchName" - val args = MainCommand.args.patchArgs?.patchingArgs!! - if (args.excludedPatches.contains(patchName)) { - logger.info("$prefix: Manually excluded") - return@patchLoop - } else if ((!patch.include || args.defaultExclude) && !args.includedPatches.contains(patchName)) { - logger.info("$prefix: Excluded by default") - return@patchLoop - } + val prefix = "Skipping $patchName" if (compatiblePackages == null) logger.trace("$patchName: No constraint on packages.") else { @@ -51,6 +42,14 @@ fun Patcher.addPatchesFiltered(allPatches: List>>) { } } + if (args.excludedPatches.contains(patchName)) { + logger.info("$prefix: Manually excluded") + return@patchLoop + } else if ((!patch.include || args.exclusive) && !args.includedPatches.contains(patchName)) { + logger.info("$prefix: Excluded by default") + return@patchLoop + } + logger.trace("Adding $patchName") includedPatches.add(patch) }