Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds deploy attribution. #18

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Adds deploy attribution. #18

merged 2 commits into from
Sep 9, 2020

Conversation

mbleigh
Copy link
Collaborator

@mbleigh mbleigh commented Sep 9, 2020

By adding the FIREBASE_DEPLOY_AGENT env variable we will be able to properly track attribution for GH Action deploys. See here.

By adding the `FIREBASE_DEPLOY_AGENT` env variable we will be able to properly track attribution for GH Action deploys.
@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Deploy preview for 7750f08:

https://action-hosting-deploy-demo--pr18-mb-attribution-yq9u0iwl.web.app

(expires Wed, 16 Sep 2020 23:12:29 GMT)

firebase-hosting-preview-action

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@jhuleatt jhuleatt added the cla: yes Contributor has signed CLA label Sep 9, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jhuleatt
Copy link
Collaborator

jhuleatt commented Sep 9, 2020

CLA bot got confused by my personal email

Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbleigh! Excited to get some stats!

@jhuleatt jhuleatt merged commit 7b568e9 into main Sep 9, 2020
pomle pushed a commit to pomle/action-hosting-deploy that referenced this pull request Nov 8, 2020
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants