Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doorhanger component: Understand #139

Closed
aminalhazwani opened this issue Nov 1, 2017 · 4 comments
Closed

Doorhanger component: Understand #139

aminalhazwani opened this issue Nov 1, 2017 · 4 comments
Assignees
Milestone

Comments

@aminalhazwani
Copy link
Contributor

Collect and compare doorhangers variations. Create a visual inventory and find possible edge cases.

@aminalhazwani aminalhazwani added this to the 2017.11.08 milestone Nov 1, 2017
@aminalhazwani aminalhazwani self-assigned this Nov 1, 2017
@aminalhazwani
Copy link
Contributor Author

As a first iteration I looked at doorhangers per se, without taking into consideration the content and the internal structure. I inspected doorhangers on both macOS and Windows with the Browser Toolbox.

There are a couple of differences between macOS and Windows. The biggest are corner radius and shadows. macOS has rounded corners and a stronger shadow, Windows has sharp corners and a softer shadow. Other small differences are the background and the border colors.

@aminalhazwani
Copy link
Contributor Author

aminalhazwani commented Nov 3, 2017

With mozscreenshots we can print all the different configuration for the identity popup which is another doorhanger being used https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=c1185e615e55949151f20c66d55b0e7e62034adb&newProject=mozilla-central&newRev=40a14ca1cf04499f398e4cb8ba359b39eae4e216&filter=controlCenter

I talked with the mozscreenshots engineers and it would also be possible to print all the doorhanger available in Firefox but a configuration would be needed.

@aminalhazwani
Copy link
Contributor Author

Here another very valuable document that explain the rational behind doorhangers, their structure, their content and more https://bug1064257.bmoattachments.org/attachment.cgi?id=8504734

@brassy- brassy- closed this as completed Nov 8, 2017
@aminalhazwani
Copy link
Contributor Author

Interesting bug on bugzilla that might come useful for the second iteration on doorhangers https://bugzilla.mozilla.org/show_bug.cgi?id=1374339 and https://bugzilla.mozilla.org/show_bug.cgi?id=1409301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants