From 2d48de96a953c512d548b8b682dc5604dd658c63 Mon Sep 17 00:00:00 2001
From: Sahana R <sahanar1191@gmail.com>
Date: Sat, 1 Aug 2020 17:20:21 +0530
Subject: [PATCH 1/2] ADD: Max length check added to Feature, Segment and
 Traits ID

---
 common/constants.js                    | 9 ++++++++-
 web/components/modals/CreateFlag.js    | 7 +++++--
 web/components/modals/CreateSegment.js | 6 +++++-
 web/components/modals/CreateTrait.js   | 4 ++++
 4 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/common/constants.js b/common/constants.js
index 1104417e..eff60435 100644
--- a/common/constants.js
+++ b/common/constants.js
@@ -29,6 +29,13 @@ const Constants = {
         '#039587',
         '#344562',
     ],
+    forms: {
+        maxLength: {
+            "FEATURE_ID" : 256,
+            "SEGMENT_ID" : 256,
+            "TRAITS_ID" : 256
+        },
+    },
     defaultRule: {
         property: '',
         operator: 'EQUAL',
@@ -159,7 +166,7 @@ const Constants = {
             'Node JS': require('./code-help/install/install-node')(keywords),
             'Java': require('./code-help/install/install-java')(keywords),
             '.NET': require('./code-help/install/install-dotnet')(keywords),
-        },
+        }, 
     },
     simulate: {},
     roles: {
diff --git a/web/components/modals/CreateFlag.js b/web/components/modals/CreateFlag.js
index 6703fbf7..d83f2928 100644
--- a/web/components/modals/CreateFlag.js
+++ b/web/components/modals/CreateFlag.js
@@ -7,6 +7,9 @@ import data from '../../../common/data/base/_data';
 import SegmentOverrides from '../SegmentOverrides';
 import AddEditTags from '../AddEditTags';
 import TagList from '../TagList';
+import Constants from '../../../common/constants';
+
+const FEATURE_ID_MAXLENGTH = Constants.forms.maxLength.FEATURE_ID;
 
 const CreateFlag = class extends Component {
     static displayName = 'CreateFlag'
@@ -114,7 +117,7 @@ const CreateFlag = class extends Component {
         const Provider = identity ? IdentityProvider : FeatureListProvider;
         const valueString = isEdit ? 'Value' : 'Initial value';
         const enabledString = isEdit ? 'Enabled' : 'Enabled by default';
-
+       
         return (
             <ProjectProvider
               id={this.props.projectId}
@@ -163,7 +166,6 @@ const CreateFlag = class extends Component {
                                         </Tabs>
                                     </FormGroup>
                                 )}
-
                                 <FormGroup className="mb-4 mr-3 ml-3">
                                     <InputGroup
                                       ref={e => this.input = e}
@@ -172,6 +174,7 @@ const CreateFlag = class extends Component {
                                           readOnly: isEdit,
                                           className: 'full-width',
                                           name: 'featureID',
+                                          maxLength: FEATURE_ID_MAXLENGTH,
                                       }}
                                       value={name}
                                       onChange={e => this.setState({ name: Format.enumeration.set(Utils.safeParseEventValue(e)).toLowerCase() })}
diff --git a/web/components/modals/CreateSegment.js b/web/components/modals/CreateSegment.js
index 1565e0f4..4ba4d2dd 100644
--- a/web/components/modals/CreateSegment.js
+++ b/web/components/modals/CreateSegment.js
@@ -3,6 +3,9 @@ import engine from 'bullet-train-rules-engine';
 import Rule from './Rule';
 import Highlight from '../Highlight';
 import SegmentStore from '../../../common/stores/segment-list-store';
+import Constants from '../../../common/constants';
+
+const SEGMENT_ID_MAXLENGTH = Constants.forms.maxLength.SEGMENT_ID;
 
 const CreateSegment = class extends Component {
     static displayName = 'CreateSegment'
@@ -167,7 +170,8 @@ const CreateSegment = class extends Component {
                               inputProps={{
                                   className: 'full-width',
                                   name: 'segmentID',
-                                  readOnly: isEdit
+                                  readOnly: isEdit,
+                                  maxLength: SEGMENT_ID_MAXLENGTH
                               }}
                               value={name}
                               onChange={e => this.setState({ name: Format.enumeration.set(Utils.safeParseEventValue(e)).toLowerCase() })}
diff --git a/web/components/modals/CreateTrait.js b/web/components/modals/CreateTrait.js
index 2a35b2b4..cadb050b 100644
--- a/web/components/modals/CreateTrait.js
+++ b/web/components/modals/CreateTrait.js
@@ -1,5 +1,8 @@
 import React, { Component } from 'react';
 import Highlight from '../Highlight';
+import Constants from '../../../common/constants';
+
+const TRAITS_ID_MAXLENGTH = Constants.forms.maxLength.TRAITS_ID;
 
 const CreateTrait = class extends Component {
     static displayName = 'CreateTrait'
@@ -62,6 +65,7 @@ const CreateTrait = class extends Component {
                                           readOnly: isEdit,
                                           className: 'full-width',
                                           name: 'traitID',
+                                          maxLength: TRAITS_ID_MAXLENGTH,
                                       }}
                                       value={trait_key}
                                       onChange={e => this.setState({ trait_key: Format.enumeration.set(Utils.safeParseEventValue(e)).toLowerCase() })}

From f039dc409df2c10fed48048d7ed8220b616ee690 Mon Sep 17 00:00:00 2001
From: Sahana R <sahanar1191@gmail.com>
Date: Sat, 1 Aug 2020 17:37:39 +0530
Subject: [PATCH 2/2] ADD: feature, segment and traits Id's max length is
 configured

---
 common/constants.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/constants.js b/common/constants.js
index eff60435..9b1c0df7 100644
--- a/common/constants.js
+++ b/common/constants.js
@@ -31,9 +31,9 @@ const Constants = {
     ],
     forms: {
         maxLength: {
-            "FEATURE_ID" : 256,
-            "SEGMENT_ID" : 256,
-            "TRAITS_ID" : 256
+            "FEATURE_ID" : 150,
+            "SEGMENT_ID" : 150,
+            "TRAITS_ID" : 150
         },
     },
     defaultRule: {