Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing EU flag and inability to use alpha-2 codes #35

Open
mscno opened this issue Oct 25, 2023 · 2 comments
Open

Missing EU flag and inability to use alpha-2 codes #35

mscno opened this issue Oct 25, 2023 · 2 comments

Comments

@mscno
Copy link

mscno commented Oct 25, 2023

Hi, thanks for a great library.

Made it super easy to add flags to my phx app.

Two suggestions for improvements:

  1. Add the ability to use alpha-2 codes. The alpha-2 codes are far more prevalent across all other geo tools and databases that I have ever worked with, and for me at least, alpha-2 codes are way more natural to work with.
  2. The current focus on alpha-3 codes leaves out all the flags in flagpack that do not have a value defined for the alpha-3 column, example: The European Union flag, Rainbow flag etc. It would be great to have these included as well.
@Flo0807
Copy link
Owner

Flo0807 commented Oct 28, 2023

Hi @mscno, I really appreciate your feedback. It is great to hear that my library is being actively used. I did not know that alpha-2 codes are much more common as I do not work with geo-tools and databases often. I see your point about the European Union flag and the rainbow flag.

What do you think about a complete switch to alpha-2 function names? The flag/1 component could still support all types of codes: alpha-2, alpha-3 and numeric.

@mscno
Copy link
Author

mscno commented Nov 6, 2023

I would love that!

I think alpha-2 codes are the right way forward. And the generic flag/1 component would be a good way to keep support for alpha 3 codes if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants