Merged
Conversation
Member
|
No breaking changes here right? This will go with next release or 1.9.0? |
Member
Author
Yeah no breaking change.
I think so? If this performs well. |
jjw24
added
enhancement
jjw24
approved these changes
Aug 16, 2021
jjw24
removed
the
review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to provide a virtual method separately for query, context menu, and callback. The virtual method should only provide a way to pass the request model to the executable or something received the jsonrpc request.
Query, ContextMenu, and Callback should be indicated within the JsonRPC model.