Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better device proxy cache #4792

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Better device proxy cache #4792

wants to merge 5 commits into from

Conversation

hardillb
Copy link
Contributor

part of #3414

Description

Rather than requesting the 4 largest files from the device agent every time the device editor is loaded it will load them from a local instance on @node-red/editor-client of the matching version if present.

Still need to work out how to install the right versions of @node-red/editor

Related Issue(s)

#3414

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 39.02439% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (4ab0fb2) to head (75ba4a6).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/lib/deviceEditor/DeviceTunnelManager.js 28.12% 23 Missing ⚠️
forge/db/controllers/Device.js 50.00% 1 Missing ⚠️
...db/migrations/20241115-01-add-nr-version-device.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4792      +/-   ##
==========================================
- Coverage   78.67%   78.56%   -0.12%     
==========================================
  Files         314      315       +1     
  Lines       15125    15163      +38     
  Branches     3483     3491       +8     
==========================================
+ Hits        11900    11913      +13     
- Misses       3225     3250      +25     
Flag Coverage Δ
backend 78.56% <39.02%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pervious code had hard coded path on my machine, this moves it to
under FLOWFORGE_HOME in `var/device/cache`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant