Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ChatOpenAI uses "parseInt" where it should use "parseFloat" instead #610

Closed
rozek opened this issue Jul 24, 2023 · 5 comments
Closed

[BUG] ChatOpenAI uses "parseInt" where it should use "parseFloat" instead #610

rozek opened this issue Jul 24, 2023 · 5 comments

Comments

@rozek
Copy link

rozek commented Jul 24, 2023

Describe the bug
the "topP" parameter is parsed using parseInt rather than parseFloat
@rozek
Copy link
Author

rozek commented Jul 24, 2023

the "OpenAI" llm has the same problem...

@HenryHengZJ
Copy link
Contributor

nice spot! will fix that

@rozek
Copy link
Author

rozek commented Jul 25, 2023

Thank you very much!

Both for this fix in particular and Flowise in general!

@chungyau97
Copy link
Contributor

#617

@HenryHengZJ
Copy link
Contributor

closing as #617 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rozek @HenryHengZJ @chungyau97