Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceSetViewHelperTrait encodes image URI twice #1512

Closed
luzat opened this issue Aug 29, 2018 · 2 comments
Closed

SourceSetViewHelperTrait encodes image URI twice #1512

luzat opened this issue Aug 29, 2018 · 2 comments

Comments

@luzat
Copy link
Contributor

luzat commented Aug 29, 2018

When using images containing umlauts (e.g. zubehör.jpg) with v:media.image and srcset the src is set correctly, but in srcset the file name is double-encoded, that is ö => %C3%B6 => %25C3%25B6. It seems that this happens because of this line in SourceSetViewHelperTrait.php:

$srcsetVariantSrc = static::preprocessSourceUri(GeneralUtility::rawUrlEncodeFP($srcsetVariantSrc), $this->arguments);

static::preprocessSourceUri encodes the string as does GeneralUtility::rawUrlEncodeFP. Just changing the line to

$srcsetVariantSrc = static::preprocessSourceUri($srcsetVariantSrc, $this->arguments);

gets rid of a deprecated call and outputs both src and srcset correctly with %C3%B6.

@NamelessCoder
Copy link
Member

Removed in 9af62c4

@luzat
Copy link
Contributor Author

luzat commented Jan 3, 2023

GeneralUtility::rawUrlEncodeFP is removed, but the encoding is still superfluous (and breaks image references where double encoding breaks the URI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants