Fix some typos in docs #2418
Merged
Fix some typos in docs #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloLucibello
approved these changes
Mar 31, 2024
ToucheSir
reviewed
Mar 31, 2024
| @@ -8,7 +8,7 @@ To introduce Flux's recurrence functionalities, we will consider the following v | |||
|
|
|||
| In the above, we have a sequence of length 3, where `x1` to `x3` represent the input at each step (could be a timestamp or a word in a sentence), and `y1` to `y3` are their respective outputs. | |||
|
|
|||
| An aspect to recognize is that in such a model, the recurrent cells `A` all refer to the same structure. What distinguishes it from a simple dense layer is that the cell `A` is fed, in addition to an input `x`, with information from the previous state of the model (hidden state denoted as `h1` & `h2` in the diagram). | |||
| An aspect to recognise is that in such a model, the recurrent cells `A` all refer to the same structure. What distinguishes it from a simple dense layer is that the cell `A` is fed, in addition to an input `x`, with information from the previous state of the model (hidden state denoted as `h1` & `h2` in the diagram). | |||
There was a problem hiding this comment.
Sorry, didn't get around to this in time. In case this comes up again, most of the Flux core team uses the American spelling. Not worth a whole change now, but I wanted to have that known if anyone sees this change and wants to make a similar one.
There was a problem hiding this comment.
I had the impression that mostly British spelling is used (e.g. it is called Optimiser.jl and not Optimizer.jl).
There was a problem hiding this comment.
The original author was from the UK. Unfortunately we can't change package names so easily, but everything else uses the non-british spelling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While browsing through the docs, I found some small typos here and there.
PR Checklist