Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix component arrays test #2419

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix component arrays test #2419

merged 2 commits into from
Apr 4, 2024

Conversation

CarloLucibello
Copy link
Member

Fix #2411

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.13%. Comparing base (348c56f) to head (7b71e2c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2419   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files          32       32           
  Lines        1877     1877           
=======================================
  Hits          866      866           
  Misses       1011     1011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't quite follow the discussion in #2411, is it not possible to use ComponentArrays with implicit params any more?

@CarloLucibello
Copy link
Member Author

I don't know. Also, I'm not too interested into delving into the problem since params is going away.

@CarloLucibello
Copy link
Member Author

bump

@CarloLucibello CarloLucibello merged commit caa1cee into master Apr 4, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests are failing due to ComponentArrays
3 participants