Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference fixed Roslyn version #1081

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

ltrzesniewski
Copy link
Member

@ltrzesniewski ltrzesniewski commented Aug 10, 2024

This follows my remark from here:

Oh, I didn't notice this earlier, but I think the Microsoft.CodeAnalysis.CSharp package should be rolled back to v4.0.1 and frozen at that version unless there's a good reason to use a newer one, since referencing a newer version requires the user to have a .NET SDK or Visual Studio version which supports it. See here for the version map.

The problem is that it won't play along with tools which always suggest to bump the packages to the latest versions. 😞

So this ensures the analyzer supports older compilers, but runs tests with the latest one. Contrary to my previous remark, IDEs won't suggest updating Microsoft.CodeAnalysis.CSharp.

What do you think @tom-englert?

This ensures the analyzer supports older compilers.
@ltrzesniewski ltrzesniewski added the dependencies Pull requests that update a dependency file label Aug 10, 2024
@SimonCropp SimonCropp merged commit 25f4b7f into Fody:master Aug 10, 2024
2 checks passed
@ltrzesniewski ltrzesniewski deleted the fixed-roslyn-analyzers branch August 10, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants