Add checks for navigation collections #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
ejsmith
added a commit
that referenced
this pull request
Aug 24, 2024
* Working on EF SQL adapter * Progress * Small progress * Some progress on SQL translation * Progress * Progress * More progress * Fix test * Fix tests * More ways to get entitytype * Params * More refactoring * More refactoring * More refactor * Make copy of cached fields so they don't get polluted * Add entity type filter * Change to navigation filter * Add date support * Add default field search support * Adding support for junction tables. Better recursion detection. * Don't exit on collections * Fix build warnings * Fix collection field support on default fields * Add support for money data type * PR feedback * Date math and fixed missing and exists * Fix double validation * Allow controlling what includes are called * Allow changing include name * Add checks for navigation collections (#80) * test(sql): add tests for using navigations * fix: correct tests to highlight navigation bug * fix: add check if skip navigation is collection * test: add checks to confirm skip navigations * fix: respect ISkipNavigation#IsCollection * Update deps * Dummy change --------- Co-authored-by: Luke Gordon <gordysc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SqlQueryParser#AddEntityFields to respect collection navigations instead of hard coding false