Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial changes for v1beta2 CRD #1077

Merged
merged 10 commits into from
Mar 10, 2022
Merged

Initial changes for v1beta2 CRD #1077

merged 10 commits into from
Mar 10, 2022

Conversation

johscheuer
Copy link
Member

@johscheuer johscheuer commented Mar 2, 2022 •
edited
Loading

Description

Fixes: #1047
Fixes: #895
Fixes: #833
Fixes: #551

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Discussion

This adds a new CRD v1beta2, which will be the default stored version. Internally the operator will use v1beta1 until we change this in the next release.

Testing

Unit tests + local tests.

I tested different settings:

  • Cluster v1beta1 -> v1beta2 (worked if old/deprecated settings are there they will be dropped)
  • Creating new clusters

Documentation

Added some additional docs.

Follow-up

After this we can change the default internal type of the operator to v1beta2 and remove some additional code.

@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 7d222b6ec9f39d9b1fa07361e5419c12fef6fac7
  • Result: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

@johscheuer johscheuer marked this pull request as ready for review March 3, 2022 12:20
@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 0102f8ee868ddf229da16cdffc23d54cd2768b70
  • Result: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 6e9c6bd13d048897d62850afeda3708bb430e196
  • Result: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: cbe934fe08b5f9627aabe5b2fd69a7ad29eed1b5
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 4e1193bb510e192b4453a3e5cbf589e6d10bcba0
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

@johscheuer johscheuer added this to the 1.0 milestone Mar 4, 2022
@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 5cc8613baf38ce2c57d7015543544d4289a39639
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

@johscheuer
Copy link
Member Author

The e2e test pipeline will fail until we upgrade the CRD in our test cluster(s).

@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 331a74ff9e0c78e8c659b0eb3f277ebdd5041dfa
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

brownleej
brownleej approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@brownleej brownleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

config/samples/apps_v1beta2_foundationdbcluster.yaml Outdated Show resolved Hide resolved
johscheuer
johscheuer commented Mar 10, 2022
View reviewed changes
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to rebase those changes and add all changes that were merged for v1beta1 to v1beta2 after that I would merge those changes and start writing the change-log for 1.0.0

@johscheuer
Copy link
Member Author

I think I have all deprecations updated for v1beta2.

@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 2c9b2db
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

@johscheuer johscheuer merged commit 8e7b71a into FoundationDB:main Mar 10, 2022
@johscheuer johscheuer deleted the v1beta2 branch March 10, 2022 13:21
09harsh pushed a commit to 09harsh/fdb-kubernetes-operator that referenced this pull request Aug 1, 2022
@johscheuer
Initial changes for v1beta2 CRD (FoundationDB#1077)
56c386d 
* Initial changes for v1beta2 CRD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brownleej brownleej brownleej approved these changes

@JoshuaMcManus JoshuaMcManus Awaiting requested review from JoshuaMcManus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
3 participants
@johscheuer @foundationdb-ci @brownleej