Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload button on mobile should display warning/info #2

Open
lourot opened this issue Jun 7, 2023 · 2 comments
Open

Upload button on mobile should display warning/info #2

lourot opened this issue Jun 7, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lourot
Copy link
Member

lourot commented Jun 7, 2023

Since https://frameright.app works only on desktop, it is unlikely that, as of today, the user will have pictures with Image Regions on their phone. Thus when clicking on Upload on their phone, we should tell them to better switch to desktop for now.

@lourot lourot added enhancement New feature or request good first issue Good for newcomers labels Jun 7, 2023
@ilu
Copy link
Member

ilu commented Jun 8, 2023

I would keep the behavior as is. I think it is an excellent demo if a person has been able to move an image with IDC metadata onto their phone, even if they have not created it on that device. We could show them a message on mobile guiding them to create the IDC metadata on desktop but still have the possibility to upload on mobile too.

@lourot
Copy link
Member Author

lourot commented Jun 8, 2023

After chatting with @MarinaEkroos, let's think about it more. If it's hard to transfer images to a phone without losing metadata at the moment, we might as well remove the Upload button on mobile and replace it with a third picture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants