-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Code to QMK Coding Guidelines for keyboard_post_init_user() #40
base: fl16-v0.2.8-prep
Are you sure you want to change the base?
Align Code to QMK Coding Guidelines for keyboard_post_init_user() #40
Conversation
Thank you for your contribution! |
Not stale. still waiting for review |
…ayer_state_set_user" endlessly
Thank you for your contribution! |
not stale |
Thank you for your contribution! |
As mentioned in the QMK Guidelines all _user() functions should optimally (in best case never) used by the keyboards to be available for the keymap / user to implement own stuff.
Description
In your Macropad and Numpad keyboard you used keyboard_post_init_user() which should be used on keymap instead of keyboard level. For this i moved the functions to their respective default keymap, where they should be. The same or even more is important for layers which are specific for each keymap and should definitely only defined inside the respective keymaps (user-wide keymaps are an exception but since this is a keyboard folder, it is not applicable)
This Default keymap also serves as template to create an own keymap layout, so the code is still visible for everyone who wants to create or fork from it.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
PS: If approved and considered correct, pls ping me and i would like to fix the other _user() functions too, that i found. Want to avoid doing multiple PRs for nothing if you guys think otherwise and remodel it differently.