Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip frequently updated files #24

Open
Freaky opened this issue May 4, 2020 · 5 comments
Open

Skip frequently updated files #24

Freaky opened this issue May 4, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@Freaky
Copy link
Owner

Freaky commented May 4, 2020

Files that get updated a lot, particularly if they're large, are poor candidates for compaction.

An obvious simple heuristic that seems likely to be relatively effective is to check file modification time, and simply have a configurable cutoff - if it's changed in the past n days, skip it. Tiering this by file size might also make sense - frequently decompressing and recompressing a small file is much less costly than a large one.

This sort of thing will be more important should Compactor migrate to a background system service with patrol compactions.

@Freaky Freaky added the enhancement New feature or request label May 4, 2020
@alpe12
Copy link

alpe12 commented Aug 4, 2020

Yeah, I was going to suggest this.
Even without tiering an option to set this cutoff would be very useful.

@alpe12
Copy link

alpe12 commented Mar 1, 2021

@Freaky Please, take a look at adding this cutoff by modified time. Thanks.

@Freaky
Copy link
Owner Author

Freaky commented Mar 1, 2021

Will be getting to it soon!

@Freaky
Copy link
Owner Author

Freaky commented Dec 20, 2022

What I said but really this time.

compactor-0 11-settings

@ThoughtPhotography
Copy link

Any chance of adding a download link for the newest development build for those comfortable with pre-releases?

What I said but really this time.

compactor-0 11-settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants