From 657c3fe07bdc9b699a8a16952bb4f1d59fe672ef Mon Sep 17 00:00:00 2001 From: FrankQiu Date: Fri, 6 Nov 2020 11:59:49 +0800 Subject: [PATCH] Docs: added a Pull Request Guidelines in CONTRIBUTING.md (#1520) * fix: updated snapshot and added shein logo and website * chore: deleted alias in installOptions * chore: deleted alias in installOptions * chore: drop the alias in installOptions in SnowpackConfig interface * docs: added a Pull Request Guidelines * [ci] yarn format * docs: submitted a revised pull request guidelines. * [ci] yarn format * Update CONTRIBUTING.md Co-authored-by: iam-frankqiu Co-authored-by: Fred K. Schott --- CONTRIBUTING.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6b1feec8ce..356d0c1e18 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -109,6 +109,19 @@ Note the path must start with must start with a `.` to be considered local The `--verbose` flag enables additional logs which will help to identify the source of a problem. The `--reload` will clear the local cache which might have been created by a different `snowpack` version. Learn more about [Snowpack's CLI flags](https://www.snowpack.dev/#cli-flags). +## Pull Request Guidelines + +Checkout a topic branch from a base branch, e.g. `master`, and merge back against that branch. + +If adding a feature, it probably should have been brought up in a [discussion](https://github.com/snowpackjs/snowpack/discussions) instead before the PR was created. + +Some tips for creating your first pull request: + +- Provide background for why a PR was created. +- Link to any relevant issues, discussions, or past PRs. +- Add accompanying tests if applicable. +- Ensure all tests have been passed. + ## Discussion [Join the Pika Discord](https://discord.gg/rS8SnRk)