Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal external-editor-revived (for NativeMessagingHosts) #34

Closed
ondohotola opened this issue Jul 10, 2022 · 10 comments · Fixed by #38
Closed

Universal external-editor-revived (for NativeMessagingHosts) #34

ondohotola opened this issue Jul 10, 2022 · 10 comments · Fixed by #38
Labels
enhancement New feature or request

Comments

@ondohotola
Copy link

Description

It works on both the X_86 and on the M1. As it is a pure X_83 app it'll use Rosetta.
Cmd-E works as well (in favour of the Ctrl-E (on the Mac))

Is would it be possible to modify the compile process to generate a Universal app for the Mac, please?

greetings, el

Environment

  • OS: Darwin XXXXXXX 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:29 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T8101 arm64
  • OS: Darwin XXXXXXX 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64
  • Thunderbird version: 91.11.0/
  • ExtEditorR extension version: 0.2.0
  • ExtEditorR host version: External Editor Revived native messaging host v0.2.0

Configuration

/Applications/Alpha.app/Contents/Resources/alphac

@Frederick888 Frederick888 added the enhancement New feature or request label Jul 10, 2022
@Frederick888
Copy link
Owner

Frederick888 commented Jul 10, 2022 via email

@ondohotola
Copy link
Author

ondohotola commented Jul 10, 2022 via email

@Frederick888 Frederick888 mentioned this issue Jul 11, 2022
3 tasks
@Frederick888
Copy link
Owner

Could you (or anyone watching this with an M1 machine) give the binaries from [1][2] a shot?

According to build logs they feature both x86_64 and aarch64:

$ file target/release/external-editor-revived
target/release/external-editor-revived: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]
target/release/external-editor-revived (for architecture x86_64):	Mach-O 64-bit executable x86_64
target/release/external-editor-revived (for architecture arm64):	Mach-O 64-bit executable arm64

They looked ok on my Intel MacBook.

[1] https://github.com/Frederick888/external-editor-revived/actions/runs/2648189295
[2] https://github.com/Frederick888/external-editor-revived/releases/tag/untagged-ff629f64e2f3a70db82f

@ondohotola
Copy link
Author

ondohotola commented Jul 11, 2022 via email

@ondohotola
Copy link
Author

ondohotola commented Jul 11, 2022 via email

@Frederick888
Copy link
Owner

Hmm... Link [2] was a test release that's in draft state. Perhaps it's not public.

No worries, it should be the same as the ones from [1].

@ondohotola
Copy link
Author

ondohotola commented Jul 11, 2022 via email

@Frederick888
Copy link
Owner

A friend of mine helped me test this out on M1 :)

It was working as expected. Only friction was that because the binary wasn't signed, he needed to right click Open for the first time. xattr -c I usually do probably does the same thing, and I guess I can drop a small note in wiki.

And I added the targeting OS/arch to -v output, e.g.

$ ./external-editor-revived -v
External Editor Revived native messaging host for linux (x86_64) v0.2.0

(M1 should be macos (aarch64), M1 with Rosetta should be macos (x86_64) IIUC how Rosetta works.)

Let me know if you see different results when you test it. But I think it should be alright and I plan to get a new release out over the weekend.

@ondohotola
Copy link
Author

ondohotola commented Jul 15, 2022 via email

@Frederick888
Copy link
Owner

No drama on 12.4 arm64/x86 with the pure x86 and also with the (experimental) Universal.

Ah, my brain somehow interpreted this as 'no drama on 12.4 arm64 [with Rosetta], [also no drama on] x86 with the pure x86 and also with the (experimental) Universal'.

All good then. Thanks again for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants