Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server process keeps running when parent gets killed #1552

Closed
victorbnl opened this issue Jan 14, 2023 · 0 comments · Fixed by #1553
Closed

Server process keeps running when parent gets killed #1552

victorbnl opened this issue Jan 14, 2023 · 0 comments · Fixed by #1553

Comments

@victorbnl
Copy link
Contributor

victorbnl commented Jan 14, 2023

When killing the parent process, aka ungit, the child process, server.js, keeps running. This constitutes an issue in the context of editor extensions for instance, where closing the editor does not kill ungit's server, so running ungit then keeps saying "ungit already running".

It seems this might be related to #1537. I feel like their pull request uses a bit of a hacky workaround to the arguments issue, which is as far as I know, more of a yargs issue.

If it fixes the issue, I'd suggest coming back to using spawn and find another workaround for the former issue instead, if possible.

Edit: after testing, it seems Hirse's PR is not the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant