-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forum: emoji size out of proportion in default theme (also when not signed-in) #61
Comments
@yorikvanhavre the class selectors are |
This is still an issue, reopening |
Maybe the |
Ok, it just needed to be pushed to the server. This issue is fixed! |
stylesheet doesn't apply to those not logged in.
|
seriously? |
as a heart attack. 💔 |
Can you make sure by logging in and hard refreshing pages that have the 'newer' emojis on them? |
@yorikvanhavre can you weigh in? |
i forgot i posted this thread in the forum a while back, https://forum.freecadweb.org/viewtopic.php?f=8&t=52663 so i guess all the styling for the forum and wiki are contained within this git repo. 👍 |
Indeed. I have merge permissions on this repo...so feel free to submit PRs and I'll test them. |
that emoji class you added to the stylesheet isn't being added to the stylesheet when i visit the freecad forum, as evident when viewing the assets for the forum in this image below, if you do a search for as evident from viewing the commit you made, the emoji class so if i had to take a shot in the dark maybe the assets haven't been compiled since you pushed your changes to this repo. i don't know how this whole infrastructure works, in hwo the actual server picks the code from this repo and then renders it, so i can't really comment on that. but i hope this helps in further understanding of what is going on. |
@kkremitzki you have experience with sass? |
Afraid not. This broke again because there were breaking changes to the theme our FreeCAD and FreeCAD-Dark themes are based on... it would be good to have something a little more maintainable. |
Issue: https://forum.freecadweb.org/viewtopic.php?t=32722
Console warning:
This is the expected behavior: switch over to the elegance theme (i'm using the Firefox 'Dark Reader' addon hence the dark theme)
The text was updated successfully, but these errors were encountered: