Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Providers and ViewModels #156

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Refactor: Providers and ViewModels #156

merged 11 commits into from
Apr 4, 2024

Conversation

FriesI23
Copy link
Owner

@FriesI23 FriesI23 commented Apr 3, 2024

No description provided.

@FriesI23 FriesI23 added the code quality Code improvement suggestions label Apr 3, 2024
@FriesI23 FriesI23 self-assigned this Apr 3, 2024
- remove `getProtoDateByFreqChartCombinei`
- remove `getProtoDateByScoreChartCombine`
- modify `provider/utils/*` to `provider/utils.dart`
- cancel loading when detail/summary viewmodel disposing
Copy link
Owner Author

@FriesI23 FriesI23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need fixed

lib/provider/_utils/habit_chart_utils.dart Outdated Show resolved Hide resolved
lib/provider/habit_detail.dart Outdated Show resolved Hide resolved
lib/provider/habit_summary.dart Outdated Show resolved Hide resolved
lib/provider/habit_summary.dart Show resolved Hide resolved
lib/provider/habit_summary.dart Outdated Show resolved Hide resolved
@FriesI23 FriesI23 merged commit d81b8d3 into main Apr 4, 2024
3 checks passed
@FriesI23
Copy link
Owner Author

FriesI23 commented Apr 4, 2024

Code Refactoring

@FriesI23 FriesI23 deleted the refactor/providers branch April 8, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code improvement suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant