Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

[MHD-128] reject cases that are strictly invalid #287

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

theunkn0wn1
Copy link
Contributor

This PR resolves MHD-128.

Specifically, mecha will now reject any incoming announcement that is strictly invalid, ie the system, client, or platform are null.

@shatteredbeam
Copy link

Id change the output string to something more descriptive.

Something like 'Invalid Announcement, missing (Case Number|System|Platform)'

Otherwise its just going to confuse people not familiar with the process.

@theunkn0wn1
Copy link
Contributor Author

Given this is a fail-safe measure, and only is triggered when some other component glares at announcer goes wrong, all end users really need to know is something went wrong (strictly invalid) and that the dispatch needs to manually inject the case.

I feel specifying exactly what went wrong would only make the message longer and thus clutter the channel.

@kenneaal
Copy link
Member

Given that the announcer only forwards what the client plugin tells it, you can turn that glare of yours elsewhere. :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants