Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit UserInfo type def #95

Closed
JakeLo123 opened this issue May 13, 2024 · 3 comments · Fixed by #120
Closed

Audit UserInfo type def #95

JakeLo123 opened this issue May 13, 2024 · 3 comments · Fixed by #120
Assignees
Labels
Chalk documentation Improvements or additions to documentation DX

Comments

@JakeLo123
Copy link
Collaborator

Audit UserInfo type def.

Description

The UserInfo type definition should include all the properties that are liable to appear. I think it's only missing preferred_username atm, but it let's make sure.

Any changes need to be defined in each package in order to make types declarations available to the end user.

More Context

The userInfo property is the payload from GET /oauth2/userinfo. This type of userinfo response is an OIDC standard. (Docs for this endpoint)

This ticket was tipped off from #94

@JakeLo123 JakeLo123 added the documentation Improvements or additions to documentation label May 13, 2024
@mooreds
Copy link
Contributor

mooreds commented May 13, 2024

See the changes to 1.50 too. From the release notes:

Applications now have a new Scope Handling Policy. The Strict option provides behaviors that are more compliant with the OIDC specification, while the Compatibility option provides backwards-compatible behavior. Specifically, Strict mode limits information in access tokens and populates Id tokens and UserInfo responses based on the requested OAuth scopes. This option also restricts the UserInfo endpoint to accepting only access tokens containing the openid scope.

https://fusionauth.io/docs/lifecycle/authenticate-users/oauth/scopes#scope-handling-policy has more info.

@kasir-barati
Copy link

@mooreds So based on what I understood this endpoint GET /oauth2/userinfo should return user info based on OAuth scope, reflecting passed OAuth scope.

Is that right?

@mooreds
Copy link
Contributor

mooreds commented May 16, 2024

@kasir-barati I'd have to review the doc. https://fusionauth.io/docs/lifecycle/authenticate-users/oauth/endpoints#userinfo

I suggest you post in the community forum or open a support ticket, as that will probably get you a quicker response than tagging me.

@michaelyons michaelyons self-assigned this Jun 10, 2024
@JakeLo123 JakeLo123 linked a pull request Jun 12, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chalk documentation Improvements or additions to documentation DX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants