Handle correctly not found errors in admin and chooser parts.
#1060
Conversation
pkg/ui/admin/embed/layouts/main.html
Outdated
| <link rel="stylesheet" href="/admin/static/css/namespaces.css"> | ||
| <link rel="icon" type="image/x-icon" href="/static/chooser/favicon.ico"> | ||
| <link rel="icon" type="image/x-icon" href="/static/chooser/static/favicon.ico"> |
There was a problem hiding this comment.
/static/chooser/static seems like one-too-many static directories.
There was a problem hiding this comment.
unfortunately this is how it should be handled. we have new routes /chooser/namespaces so we can't for example start with just a chooser for our static data because it will be a collision. I tried different ways and current one is the most working.
There was a problem hiding this comment.
Well at least the sources do not have static/../static path, but it seems like there'd be a way to avoid this url path.
There was a problem hiding this comment.
let me try to play but Im not fully sure. we we can skip first static from /static/chooser/static/, then it means that we have to mount routing to just /chooser which won't work. means if we call /chooser/namespaces, it wont work, because /chooser will catch this call which is logical.
There was a problem hiding this comment.
ok, a bit reorganised everything.
What's inside the box:
not-foundpage forchooserandadminparts, where we can redirect users in case of some errors. This is hownot-foundpage looks now: