Properly save and restore the Go build cache in our CI #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiannuzzi
changed the title
suprjinx
approved these changes
Nov 8, 2023
dejanzele
reviewed
Nov 15, 2023
| - id: setup-go | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: "1.21" |
There was a problem hiding this comment.
You can parametrize the go version and keep this as a default.
go-version:
description: "Go version to install"
required: false
default: "1.21"
There was a problem hiding this comment.
yes but I don't want to have to change it in multiple places, which is why I "hard-coded" it here 😄
dejanzele
reviewed
Nov 15, 2023
| @@ -187,9 +227,9 @@ jobs: | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
do you need all git data in this job?
There was a problem hiding this comment.
we do in order to compute the version (we need tags + amount of commits since the tag)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second in a series to address #328.
It introduces a composite action to setup Go with caching. It centralizes the logic and creates a different prefixed key per job for the Go build cache. This cache is fairly small once compressed (under 100MB currently) and saves a lot of computation time. We explicitly omit the Go module cache as it is big (~1GB compressed currently) and network-bound, which means that it would raise our cache quota without any benefits compared to downloading again from the Go proxy.
The various Go tools get cached based on the Makefile
install-toolstarget content. Only the built binaries are cached (under 40MB currently) and we explicitly omit the Go build and module caches that are comparatively huge and unnecessary.The integration tests run within Docker containers and thus saving and restoring the Go build cache is a bit more complex. The high-level logic is however the same as with the other Go-based jobs.
Caches for
golangci-lint, the Docker images, and the Python tests will be improved in subsequent PRs.