Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin endpoint integration tests #560

Merged
merged 18 commits into from
Nov 10, 2023
Merged

Admin endpoint integration tests #560

merged 18 commits into from
Nov 10, 2023

Conversation

fabiovincenzi
Copy link
Collaborator

@fabiovincenzi fabiovincenzi commented Nov 6, 2023 •
edited
Loading

Fixes #512.
Introduce a new ResponseTypeHTML in the Client
It includes integration tests for the following admin endpoints:

  • Create Namespace
  • Update Namespace
  • Delete Namespace

dsuhinin
dsuhinin previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just few remarks.

dsuhinin
dsuhinin approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@fabiovincenzi fabiovincenzi merged commit 750f899 into G-Research:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuhinin dsuhinin dsuhinin approved these changes

@suprjinx suprjinx Awaiting requested review from suprjinx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin endpoint integration tests
3 participants
@fabiovincenzi @suprjinx @dsuhinin