Show namespace.Code in chooser #623
Conversation
|
|
pkg/ui/chooser/embed/index.html
Outdated
| <u>{{.CurrentNamespace.Code}}</u> | ||
| {{ if ne "" .CurrentNamespace.Description }} | ||
| - {{ .CurrentNamespace.Description }} | ||
| {{ end }} |
There was a problem hiding this comment.
I think we should apply this logic everywhere for consistency, probably by computing this before passing it to the template (as e.g. DisplayName)
There was a problem hiding this comment.
afaik this is the only place -- it looked strange to do this in the listing because the lengths were so different
There was a problem hiding this comment.
But the listing is probably where the description is the most useful if we display it, no?
I think we either don't display the description in the chooser at all, or we display it everywhere in the chooser.
There was a problem hiding this comment.
I guess it looked strange because the namespaces are displayed centred, but this might also be an issue when you have codes of various lenghts. We may want to align this all differently?
There was a problem hiding this comment.
yes left-align will probably look better, i'll try it
There was a problem hiding this comment.
could you please make the text left-aligned and move the arrow to the left of it?
also, I think it might look better with the description in parentheses, and with the default namespace being described as "Default namespace".
e.g.
custom 1
custom2 (has description)
→ default (Default namespace)
Alter namespace display in Chooser to show the namespace code instead of description. Description is shown in the "current namespace" area where it exists.
Fixes #622