Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test NaN metrics values. #659

Merged
merged 5 commits into from
Dec 2, 2023
Merged

Test NaN metrics values. #659

merged 5 commits into from
Dec 2, 2023

Conversation

dsuhinin
Copy link
Collaborator

@dsuhinin dsuhinin commented Nov 28, 2023 •
edited
Loading

What's inside the box:

  • increase integration tests coverage for NaN, +Infinite, -Infinite values.

@dsuhinin dsuhinin added the tests label Dec 1, 2023
@dsuhinin dsuhinin marked this pull request as ready for review December 1, 2023 11:11
suprjinx
suprjinx approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsuhinin dsuhinin merged commit 04ca06b into G-Research:main Dec 2, 2023
@dsuhinin dsuhinin deleted the dsuhinin/nan-values-tests branch December 2, 2023 19:44
@dsuhinin dsuhinin linked an issue Dec 4, 2023 that may be closed by this pull request
Test NaN metric values everywhere #441
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suprjinx suprjinx suprjinx approved these changes

@fabiovincenzi fabiovincenzi Awaiting requested review from fabiovincenzi

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test NaN metric values everywhere
2 participants
@dsuhinin @suprjinx