Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New migration to remove the old experiments_name_key for main branch #664

Merged
merged 3 commits into from
Nov 30, 2023
Merged

New migration to remove the old experiments_name_key for main branch #664

merged 3 commits into from
Nov 30, 2023

Conversation

suprjinx
Copy link
Contributor

@suprjinx suprjinx commented Nov 28, 2023 •
edited
Loading

Needed to move context migrations to fall after this one
Fixes #662

@suprjinx suprjinx marked this pull request as ready for review November 28, 2023 18:26
dave-gantenbein
dave-gantenbein approved these changes Nov 30, 2023
View reviewed changes
Copy link

@dave-gantenbein dave-gantenbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@suprjinx suprjinx merged commit 37c13f7 into G-Research:main Nov 30, 2023
@suprjinx suprjinx deleted the remove-exp-name-cosntraint-main branch November 30, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-gantenbein dave-gantenbein dave-gantenbein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove experiment.name unique constraint
2 participants
@suprjinx @dave-gantenbein