Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MLFlow integration tests to 2.9.2 #763

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

jgiannuzzi
Copy link
Member

This PR upgrades our MLFlow integration tests to 2.9.2, enables a few additional tests (artifacts and path validation), disables the SQLite memory backend, and makes a few changes to our code for increased compatibility with MLFlow:

  • the file:// prefix gets added to the default artifact root when a local path is provided
  • a distinction is made between generic SQL errors and a run not being found when trying to delete a run tag
  • the error message returned for an invalid path has been changed to "Invalid path" (and the validation logic has been DRYed up)
  • the error message when an inexistent run is provided has been changed to "Run 'id' not found"
  • the error message when an inexistent tag is provided to DeleteRunTag has been changed to "No tag with name: key"
  • the validator for LogBatch is more exhaustive

Our own tests have also been updated to check for these changes.

@jgiannuzzi jgiannuzzi self-assigned this Dec 20, 2023
@jgiannuzzi jgiannuzzi added the enhancement New feature or request label Dec 20, 2023
@jgiannuzzi jgiannuzzi merged commit 3c9032a into G-Research:main Dec 20, 2023
@jgiannuzzi jgiannuzzi deleted the mlflow-tests-2.9.2 branch December 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants