Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set color to border #14

Closed
wants to merge 2 commits into from
Closed

Set color to border #14

wants to merge 2 commits into from

Conversation

saeed-lotfi
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@G00fY2 G00fY2 changed the base branch from main to develop July 11, 2021 13:36
@G00fY2
Copy link
Owner

G00fY2 commented Jul 11, 2021

This library is designed to only offer a minimal QR code scanner view. I don't think making all aspects of the overlay configurable is a good idea. Also the current border color is taken from the Android AOSP system settings app (there is a build in QR scanner in the Wifi wizard) and is therefore somewhat opinionated. 🙂

The success color is also barely visible in the current implementation as it gets set while finish() is called.

If you are looking for a fully styleable solution you should consider forking this library, create a custom activitiy based on my implementation or subscribe to #12 as this would allow a better styleable, embedded solution.

Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants