Support repos mounted with trailing @

[tclune]

Currently our convention is to mount repos with a leading @ character. There is some pressure to change this to a trailing @. We should generalize the few points that currently strip @ to strip off leading and trailing @. Then, if someone really prefers the alternative convention, they can always modify their own mepo config file.

[mathomp4]

This is probably not too hard. Something like:

string(REPLACE '@' '' foo ${foo})

could do it (assuming no future components will have an @-symbol in the middle).

The problem is changing CMakeLists.txt files throughout the repositories in every add_subdirectory() and esma_add_library() call as well, e.g.:

esma_add_subdirectories (
  @MAPL
  @GMAO_Shared
  @NCEP_Shared
  @GSW
  )

# Special case - FMS is built twice with two
# different precisions.
add_subdirectory (@FMS fms_r4)
add_subdirectory (@FMS fms_r8)

[tclune]

I think the idea in the short term will be to modify the esma_add_subdirectories() implementation. It should strip any @ chars from the argument "foo" and then check for directories named "foo" "@foo" and "foo@" and add the first of those that it finds.

We can then at our leisure remove the @'s in the various components.

Note: Ricardo wants to eliminate them entirely, though mostly because tab complete is not working for him. He may not be opposed to trailing ones. I really don't care so long as there is a consensus and we don't go back and forth. Existing was a proposed solution. Pushback is the change. And then we hold the line.