Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for fix # 58. #82

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Patch for fix # 58. #82

merged 3 commits into from
Apr 15, 2020

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Apr 15, 2020

  • The "not found" branch should have been outside the loop.

(Maybe this should be to master)

@tclune
Patch for fix # 58.
1d412dd 
  - The "not found" branch should have been outside the loop.
@tclune tclune requested a review from mathomp4 April 15, 2020 12:29
@tclune tclune requested a review from a team as a code owner April 15, 2020 12:29
tclune and others added 2 commits April 15, 2020 08:47
@tclune
Modified severity levels of messages.
81aaffd 
 - with corrected nesting, the severity of messages in
   esma_add_subdirectories.cmake can be set more appropriately.
@mathomp4
Fix misspelling
236478f
@mathomp4 mathomp4 merged commit 6947c44 into develop Apr 15, 2020
@tclune tclune deleted the feature/tclune/#58-support-variant-placement-of-@ branch April 15, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @mathomp4