Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #181 #182

Merged
merged 3 commits into from
Apr 28, 2022
Merged

fixes #181 #182

merged 3 commits into from
Apr 28, 2022

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Apr 28, 2022 •
edited
Loading

Fixes #181
technically needs this pr from gocart as well for a complete fix:
GEOS-ESM/GOCART#143

@bena-nasa bena-nasa requested review from a team as code owners April 28, 2022 17:06
@bena-nasa bena-nasa added the bugfix This fixes a bug label Apr 28, 2022
@bena-nasa bena-nasa requested a review from pcolarco April 28, 2022 17:12
@bena-nasa bena-nasa added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Apr 28, 2022
@bena-nasa bena-nasa mentioned this pull request Apr 28, 2022
Merged
adarmenov
adarmenov approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@adarmenov adarmenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the VOC block of imports looks good.

pcolarco
pcolarco approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@pcolarco pcolarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am probably reading these backwards and anyway haven't done reviews before, but I see extraneous debug print statements at 1418 and 1572

pcolarco
pcolarco approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@pcolarco pcolarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, see these removed.

mmanyin
mmanyin approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that @bena-nasa was able to track down this subtle bug.

@mmanyin mmanyin merged commit 33dd90d into main Apr 28, 2022
@mmanyin mmanyin deleted the hotfix/bmauer/#181-achem_restartskip branch April 28, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcolarco pcolarco pcolarco approved these changes

@mmanyin mmanyin mmanyin approved these changes

@adarmenov adarmenov adarmenov approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bena-nasa @adarmenov @mmanyin @pcolarco