-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GAAS work #231
Make GAAS work #231
Conversation
I'm going to block this with a label for now until we can get MAPL 2.32 with @bena-nasa's PR in. |
MAPL 2.33 is now in a PR in GEOSgcm: GEOS-ESM/GEOSgcm#497 When @sdrabenh pulls that into GEOSgcm |
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, 0 diff, bugfix |
@mathomp4 OK if we remove the DNA label? |
I think so. But do you mind if I make an update to the changelog to note "Now requires MAPL 2.32 or higher"? → I updated the changelog. |
Actually, I think this is a good reason to make this a full on minor release (1.11.0) because it requires MAPL 2.32 to BUILD as @bena-nasa had to make a new procedure in MAPL. @tclune would a minor release cover this? I don't think a major is needed since it's not like chemistry itself changed, but rather it's just a build issue in a library. |
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, 0 diff, bugfix |
@mathomp4 I'm fine with a minor release. |
Yes. Packages that use GAAS do not need to change. So it is a minor release for GAAS. And just to be pedantic ... GAAS did not change because MAPL changed. Rather the desired change exploited a new feature from MAPL. |
Prepare for release on 1/4/23
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, 0 diff, bugfix |
I think this is good then! And I see @mmanyin removed the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is zero-diff for standard runs. Trust in Ben that GAAS now operates properly.
So, this is the PR to get GAAS working after it was changed to use ExtData which was apparently never tested and relied on a non-existent feature. I have finally implemented this feature that is addressed in this companion PR in MAPL:
GEOS-ESM/MAPL#1797
In the PR here in chemistry I have updated GAAS as well as the OPS version of the ExtData2G yaml file for GAAS