Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diurnal and DOW Scaling Through HEMCO for GOCART2G #253

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

acollow
Copy link
Contributor

@acollow acollow commented Mar 14, 2023

This PR uses HEMCO to implement diurnal and day of week scaling for anthropogenic emissions and uses ExtData2G to persist emissions after 2019 without the need for duplicate emissions files for subsequent years.

@acollow acollow added the Non 0-diff The changes in this pull request are non-zero-diff label Mar 14, 2023
@acollow acollow requested review from a team as code owners March 14, 2023 19:20
@mmanyin
Copy link
Contributor

mmanyin commented Mar 14, 2023

@christophkeller - please remind me, are the resource files under HEMCO used at run-time or compile-time? In particular, could the files that are changing in this PR just as easily live under GOCART ?

@acollow
Copy link
Contributor Author

acollow commented Mar 14, 2023

This PR must be taken simultaneously with GOCART PR 216

@christophkeller
Copy link
Collaborator

All HEMCO*.rc files are evaluated at run-time. Moving them to GOCART2G could have some logic. This is what is done for GEOS-Chem: https://github.com/GEOS-ESM/geos-chem/tree/geos/develop/run/GEOS.
However, for GOCART2G the connectivities in GEOS_ChemGridComp.F90 need to match the names in HEMCOgocart2g_Diagn.rc. This is why we put them here in the first place.
Both approaches have their merits, I think.

@mmanyin
Copy link
Contributor

mmanyin commented Mar 14, 2023

Is this the point at which the yaml and rc versions of ExtData files are no longer consistent in GEOS_ChemGridComp? I think so.

@mmanyin
Copy link
Contributor

mmanyin commented Mar 14, 2023

@christophkeller - thanks for the rationale on rc file location

@acollow
Copy link
Contributor Author

acollow commented Mar 14, 2023

Yeah, the RC files can't match the capability for persisting emissions. I'm all for removing them, both from the HECMO directory and GOCART to avoid confusion but am waiting for everyone to be on the same page that they are going to disappear.

@acollow acollow changed the title Feature/acollow/persistemissionsafter2019 Diurnal and DOW Scaling Through HEMCO for GOCART2G Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants